Skip to content

Commit

Permalink
fix indentation and liquid whitespace (#273)
Browse files Browse the repository at this point in the history
  • Loading branch information
@OCram85 @daattali
OCram85 authored and daattali committed Oct 20, 2017
1 parent 52d67c0 commit 92c9cf8
Showing 1 changed file with 14 additions and 14 deletions.
28 changes: 14 additions & 14 deletions _includes/disqus.html
View file
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
{% if site.disqus %}
{%- if site.disqus -%}
<div class="comments">
<div id="disqus_thread"></div>
<script type="text/javascript">
var disqus_shortname = '{{ site.disqus }}';
/* ensure that pages with query string get the same discussion */
<div id="disqus_thread"></div>
<script type="text/javascript">
var disqus_shortname = '{{ site.disqus }}';
/* ensure that pages with query string get the same discussion */
var url_parts = window.location.href.split("?");
var disqus_url = url_parts[0];
(function() {
var dsq = document.createElement('script'); dsq.type = 'text/javascript'; dsq.async = true;
dsq.src = '//' + disqus_shortname + '.disqus.com/embed.js';
(document.getElementsByTagName('head')[0] || document.getElementsByTagName('body')[0]).appendChild(dsq);
})();
</script>
<noscript>Please enable JavaScript to view the <a href="http://disqus.com/?ref_noscript">comments powered by Disqus.</a></noscript>
var disqus_url = url_parts[0];
(function() {
var dsq = document.createElement('script'); dsq.type = 'text/javascript'; dsq.async = true;
dsq.src = '//' + disqus_shortname + '.disqus.com/embed.js';
(document.getElementsByTagName('head')[0] || document.getElementsByTagName('body')[0]).appendChild(dsq);
})();
</script>
<noscript>Please enable JavaScript to view the <a href="http://disqus.com/?ref_noscript">comments powered by Disqus.</a></noscript>
</div>
{% endif %}
{%- endif -%}

4 comments on commit 92c9cf8

@adrianharabula
Copy link
Contributor

@adrianharabula adrianharabula commented on 92c9cf8 Nov 14, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why {%- and -%} tags instead of {% and %}? I get an error while previewing with MrHyde https://github.com/FauDroids/MrHyde/issues/79

@daattali
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are legal tags, they remove whitespace. You can read about it here: https://shopify.github.io/liquid/basics/whitespace/

It's possible that the repo you commented from doesn't support it but it is legal

@OCram85
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t's possible that the repo you commented from doesn't support it but it is legal

Your're absolutely right. It really depends on the used liquid version.

@adrianharabula : You can find the github-pages included liquid version in the gem details: https://rubygems.org/gems/github-pages.

Unfortunately I didn't found any information in which liquid version the whitespace control feature was added.

@daattali
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was only added within the last year, it's fairly new

Please sign in to comment.