Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bincode to 2.0.0-rc.3 #91

Merged
merged 4 commits into from
Mar 31, 2023
Merged

Update bincode to 2.0.0-rc.3 #91

merged 4 commits into from
Mar 31, 2023

Conversation

vbkaisetsu
Copy link
Member

This branch updates bincode to 2.0.0-rc.3.

The previous implementation casts hashbrown::HashMap to Vec before serialization. In this branch, Vaporetto iterates over hashbrown::HashMap and serializes directly to avoid type casting.
This not only reduces unnecessary casting costs but also solves errors associated with updates.

@vbkaisetsu vbkaisetsu requested a review from kampersanda March 31, 2023 03:31
@vbkaisetsu vbkaisetsu marked this pull request as ready for review March 31, 2023 03:31
@vbkaisetsu vbkaisetsu enabled auto-merge (squash) March 31, 2023 03:33
@vbkaisetsu vbkaisetsu merged commit 6ee10f9 into main Mar 31, 2023
@vbkaisetsu vbkaisetsu deleted the update-bincode branch March 31, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants