Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain dict scores in model by arrays instead of tuples #29

Merged
merged 7 commits into from
Apr 1, 2022

Conversation

vbkaisetsu
Copy link
Member

@vbkaisetsu vbkaisetsu commented Apr 1, 2022

This branch maintains dictionary scores in the model by arrays instead of tuples.

Currently, dictionary scores are maintained by tuples of three scores (left, inside, right), so users cannot specify inside scores individually.
It means that users cannot specify scores depending on the context.
For example, the current framework cannot specify scores of 外国人参政権 directly.

By this change, users can specify scores individually as follows:

外国人参政権,10000 -10000 10000 10000 -10000 10000 10000,外国/人/参政/権

@vbkaisetsu vbkaisetsu marked this pull request as ready for review April 1, 2022 04:36
@vbkaisetsu vbkaisetsu requested a review from kampersanda April 1, 2022 04:36
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README-ja.md Outdated Show resolved Hide resolved
README-ja.md Outdated Show resolved Hide resolved
README-ja.md Outdated Show resolved Hide resolved
vbkaisetsu and others added 2 commits April 1, 2022 17:48
@vbkaisetsu vbkaisetsu requested a review from kampersanda April 1, 2022 08:50
Copy link
Member

@kampersanda kampersanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbkaisetsu vbkaisetsu merged commit 261e3f2 into main Apr 1, 2022
@vbkaisetsu vbkaisetsu deleted the dict-charwise-score branch April 1, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants