Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeovimGtk does not create swp files #150

Closed
keeferrourke opened this issue Sep 28, 2018 · 11 comments
Closed

NeovimGtk does not create swp files #150

keeferrourke opened this issue Sep 28, 2018 · 11 comments

Comments

@keeferrourke
Copy link

Describe the bug
NeovimGtk does not appear to create swap files when a file is opened. This leads to data loss when the editor unexpectedly quits (e.g. due to power failure).

Upon opening and editing a file, swap files are not populated in $HOME/.local/share/nvim/swap, or in the current directory.

Technical information (please complete the following information):

  • OS: Fedora 28 Workstation
  • Neovim version: v0.3.1 (Lua 5.3)
  • Neovim-Gtk build version: 0.2.0
@keeferrourke keeferrourke changed the title NeovimGtk does not creat swp files NeovimGtk does not create swp files Sep 28, 2018
@daa84
Copy link
Owner

daa84 commented Sep 28, 2018

yes, it disabled because it sometime produce neovim-gtk freeze.
the problem is that in case swap file exists - neovim show message at start and neovim currently does not allow gui show this message and gui just freeze.

New version of neovim fixes this but it still at development stage. neovim/neovim#9024
So when new version come out I enable swap files back.

@keeferrourke
Copy link
Author

Turns out that this has huge ramifications. When my computer lost power, all files that were open in NeovimGtk, regardless of whether or not they were being edited(!), ended up as 0byte files when I rebooted my computer.

I think that reliability is much more important than performance. I'd rather my editor freeze every now and then than lose hours of work. :(

@elorest
Copy link

elorest commented Oct 7, 2018

Yeah that's my problem in general with NeoVim. Vim actually still works really well despite it's age. I switch to neo vim for a couple months every year or so but eventually go back to vim because it works as expected. Last time around I tried VimR for a couple months and really liked some things about it. No longer using Mac though so I'm looking for a similar NeoVim version of Gvim. This looks somewhat promising.

@daa84
Copy link
Owner

daa84 commented Oct 7, 2018

Still think freeze with unknown reason is bad and i don't have issues with file content lose, not sure why this happens.
Think can add temporary command line option to disable this behavior neovim-gtk.

@keeferrourke
Copy link
Author

Would definitely appreciate a patch. It's frustrating having to rewrite a handful of classes more than once... let alone 3 times.

@keeferrourke
Copy link
Author

@daa84 is there an update on this?

daa84 pushed a commit that referenced this issue Nov 6, 2018
@daa84
Copy link
Owner

daa84 commented Nov 6, 2018

I add option --enable-swap, think after nvim release i remove it

@keeferrourke
Copy link
Author

I don't notice any lag or freezing with the new --enable-swap feature, fyi. I'll report back here if I do.

@XVilka
Copy link
Contributor

XVilka commented Jan 25, 2019

@daa84 so I think it is time to remove it? It is part of Neovim release now.

@keeferrourke
Copy link
Author

@daa84 is this officially fixed in the latest version of NeoVimGTK? Can this issue be closed?

@justinmk
Copy link

@daa84 daa84 closed this as completed in e9655f0 Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants