Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Structure Changes #2

Merged
merged 5 commits into from
Jul 25, 2020
Merged

[WIP] Structure Changes #2

merged 5 commits into from
Jul 25, 2020

Conversation

dOrgJelli
Copy link
Contributor

@dOrgJelli dOrgJelli commented Apr 21, 2020 •
edited by benefacto
Loading

Things in this PR:

  • Set & Load ENV_VARS from a ./.env file in the root directory using the dotenv package.
  • Git ignore ./launch.json & ./tasks.json files, ensuring no private keys are ever versioned.
  • Add ./.nvmrc file at root, ensuring dependencies and commands are always installed and run using the right version of NPM & Node. More info here.
  • Move all project files into root directory (package.json, yarn.lock,
  • Use docker image for test client
  • README updates for above
  • tsconfig.json remove bloat

NOTE: still unfinished, need to finish and test.

@benefacto benefacto self-assigned this May 30, 2020
@benefacto benefacto self-requested a review July 25, 2020 23:12
@benefacto benefacto merged commit eb93f3f into dev Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benefacto benefacto benefacto approved these changes

Assignees

@benefacto benefacto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dOrgJelli @benefacto