Skip to content

Commit

Permalink
pom: remove grizzly-framework-monitoring jar as dependency
Browse files Browse the repository at this point in the history
Motivation:
grizzly framework can dynamically enable JMX monitoring when
grizzly-framework-monitoring.jar in the classpath. Thus application
can enable monitoring by explicitly defining dependency on it if needed.

Modification:
remove grizzly-framework-monitoring jar as dependency

Result:
a final application can decide to depend on grizzly-framework-monitoring
if JMX monitoring is required.

Acked-by: Olufemi Adeyemi
Target: master
  • Loading branch information
kofemann committed Jul 19, 2019
1 parent 9bd3d49 commit 941a766
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 9 deletions.
7 changes: 7 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,13 @@ OncRpcSvc service = new OncRpcSvcBuilder()
.build();
```

## Enabling JMX based monitoring

**oncrpc4j** uses [Grizzly NIO](https://github.com/eclipse-ee4j/grizzly) framework which
comes with it's own JMX monitoring capabilities. To enable it just add `grizzly-framework-monitoring`
jar with it's dependencies into the application's classpath.
See [Grizzly framework dependencies](https://javaee.github.io/grizzly/dependencies.html) for the instructions.

## Usage with JDK 9 module system

With the provided stable automatic module name __org.dcache.oncrpc4j__, **oncrpc4j**
Expand Down
4 changes: 0 additions & 4 deletions oncrpc4j-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@
<groupId>org.glassfish.grizzly</groupId>
<artifactId>grizzly-framework</artifactId>
</dependency>
<dependency>
<groupId>org.glassfish.grizzly</groupId>
<artifactId>grizzly-framework-monitoring</artifactId>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
Expand Down
5 changes: 0 additions & 5 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -219,11 +219,6 @@
<artifactId>grizzly-framework</artifactId>
<version>${grizzly-framework.version}</version>
</dependency>
<dependency>
<groupId>org.glassfish.grizzly</groupId>
<artifactId>grizzly-framework-monitoring</artifactId>
<version>${grizzly-framework.version}</version>
</dependency>
<dependency>
<groupId>org.springframework</groupId>
<artifactId>spring-context</artifactId>
Expand Down

0 comments on commit 941a766

Please sign in to comment.