Skip to content

Commit

Permalink
Handle some TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
NicEastvillage committed Oct 20, 2023
1 parent 569581b commit 63e7568
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion cgaal-engine/src/game_structure/lcgs/symbol_checker.rs
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,6 @@ impl<'a> SymbolChecker<'a> {
let cond_res = self.check(cond)?;
if let ExprKind::Num(n) = &cond_res.kind {
return if *n == 0 {
// TODO: Promote span of e2 to span of if expression. This needs to be done for all expressions.
self.check(e2)
} else {
self.check(e1)
Expand Down
4 changes: 2 additions & 2 deletions cgaal-engine/src/game_structure/lcgs/symbol_table.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ impl Display for SymbIdx {
}
}

/// TODO
/// An entry in a [SymbolTable].
#[derive(Clone, Debug)]
struct Symbol {
name: String,
Expand Down Expand Up @@ -103,7 +103,7 @@ impl SymbolTable {
self.symbols.iter().map(|s| &s.decl_rc)
}

/// Consume the symbol table to construct a simple declaration table.
/// Consume the symbol table to construct a simple declaration list with the same ordering.
pub fn solidify(mut self) -> Vec<Decl> {
self.symbols
.drain(..)
Expand Down

0 comments on commit 63e7568

Please sign in to comment.