Merge pull request #232 from d702e20/lcgs-new-intermediate #1871

warning: use of `unwrap_or` followed by a function call --> cgaal-engine/src/parsing/mod.rs:24:10 | 24 | .unwrap_or(Expr::new_error()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| Expr::new_error())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call

use of `ok_or` followed by a function call: cgaal-engine/src/game_structure/lcgs/symbol_checker.rs#L513

warning: use of `ok_or` followed by a function call --> cgaal-engine/src/game_structure/lcgs/symbol_checker.rs:513:18 | 513 | .ok_or(SpannedError::new( | __________________^ 514 | | id.span, 515 | | format!("Unknown player '{}'.", id.text), 516 | | ))?; | |__________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call help: try this | 513 ~ .ok_or_else(|| SpannedError::new( 514 + id.span, 515 + format!("Unknown player '{}'.", id.text), 516 ~ ))?; |

use of `ok_or` followed by a function call: cgaal-engine/src/game_structure/lcgs/symbol_checker.rs#L336

warning: use of `ok_or` followed by a function call --> cgaal-engine/src/game_structure/lcgs/symbol_checker.rs:336:14 | 336 | .ok_or(SpannedError::new( | ______________^ 337 | | *span, 338 | | format!("Unknown declaration '{}'.", oi), 339 | | ))?; | |______________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call help: try this | 336 ~ .ok_or_else(|| SpannedError::new( 337 + *span, 338 + format!("Unknown declaration '{}'.", oi), 339 ~ ))?; |

use of `ok_or` followed by a function call: cgaal-engine/src/game_structure/lcgs/symbol_checker.rs#L322

warning: use of `ok_or` followed by a function call --> cgaal-engine/src/game_structure/lcgs/symbol_checker.rs:322:18 | 322 | .ok_or(SpannedError::new( | __________________^ 323 | | player_name.span, 324 | | format!("Unknown player '{}'.", player_name.text), 325 | | ))?; | |__________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call help: try this | 322 ~ .ok_or_else(|| SpannedError::new( 323 + player_name.span, 324 + format!("Unknown player '{}'.", player_name.text), 325 ~ ))?; |

use of `or` followed by a function call: cgaal-engine/src/game_structure/lcgs/symbol_checker.rs#L313

warning: use of `or` followed by a function call --> cgaal-engine/src/game_structure/lcgs/symbol_checker.rs:313:30 | 313 | oi.owner.clone().or(self.scope_owner.clone()), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.scope_owner.clone())` | = note: `#[warn(clippy::or_fun_call)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call

this expression creates a reference which is immediately dereferenced by the compiler: cgaal-engine/src/algorithms/certain_zero/search_strategy/linear_representative_search.rs#L124

warning: this expression creates a reference which is immediately dereferenced by the compiler --> cgaal-engine/src/algorithms/certain_zero/search_strategy/linear_representative_search.rs:124:58 | 124 | dist += (state.0[&state_var] - rep.0[&state_var]).unsigned_abs(); | ^^^^^^^^^^ help: change this to: `state_var` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this expression creates a reference which is immediately dereferenced by the compiler: cgaal-engine/src/algorithms/certain_zero/search_strategy/linear_representative_search.rs#L124

warning: this expression creates a reference which is immediately dereferenced by the compiler --> cgaal-engine/src/algorithms/certain_zero/search_strategy/linear_representative_search.rs:124:38 | 124 | dist += (state.0[&state_var] - rep.0[&state_var]).unsigned_abs(); | ^^^^^^^^^^ help: change this to: `state_var` | = note: `#[warn(clippy::needless_borrow)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Clippy (1.65.0)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge pull request #232 from d702e20/lcgs-new-intermediate #1871

Summary

Merge pull request #232 from d702e20/lcgs-new-intermediate #1871

Jobs

Run details

rust.yml

Annotations