Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shader doesn't fallback nicely - albedo texture isn't shown when custom shaders are disabled in-game #17

Closed
Asovrix opened this issue Nov 22, 2022 · 4 comments

Comments

@Asovrix
Copy link

Asovrix commented Nov 22, 2022

As in topic. Issue only appears on meshes which end up having part toggles added by this shader, even though original one (ACLS in this case) should fall back more nicely.
Unity_2022-11-22_04-51-26
VRChat_2022-10-22_22-30-37 039_1920x1080

@d4rkc0d3r
Copy link
Owner

d4rkc0d3r commented Nov 22, 2022

It should only happen if the _MainTex is not already an atlas and gets put into a Texture2DArray. Can you check if it really is just from merged toggles? (Also merged shader toggles fall back to show everything as on when shaders a blocked, another limitation)

@Asovrix
Copy link
Author

Asovrix commented Nov 22, 2022

Yeah, I am aware of everything defaulting to be shown with only shaders being hidden.
MainTex on body parts that are solid white on above photo are all indeed using 2DArray textures, it doesn't seem to be related to toggles, especially only now I realized that my shoes are fine even though they are toggleable.

@d4rkc0d3r
Copy link
Owner

Hmm maybe I should write those limitations down in the README. I could even add an info box that only shows up when it merges different _MainTex textures into an array.

d4rkc0d3r added a commit that referenced this issue Dec 5, 2022
@d4rkc0d3r
Copy link
Owner

3.3.0 now has merging of _MainTex as a separate option that is off by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants