Option to add custom scope #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3xt3r2909
approved these changes
Feb 13, 2023
d3xt3r2909
requested changes
Mar 1, 2023
| @@ -0,0 +1,20 @@ | |||
| abstract class Scope { | |||
There was a problem hiding this comment.
File name should be scopes (plural pls)
|
any update on this? |
|
@kgeorgek ? Are u planning to fix things from comment so we can merge or i should take over? |
Closed
|
@d3xt3r2909 sorry for the late response. I have been busy with other projects. As of now, I don't know when I will be able to update this PR. |
|
Can you take over then @d3xt3r2909 ? Seems like there's only a couple small things missing |
|
Guys, any update on this? 😅 |
|
Will do it in following days, sorry was busy with some other things |
|
Still without time, but having in mind I promise.. |
|
I am merging this PR to don't mess with committing to the fork branch since this PR is almost ready. Thanks @kgeorgek for making this available. Will open one PR to fix these comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a user configurable way to define scope when using
LinkedInUserWidgetandLinkedInAuthCodeWidget. This leaves the default scope asr_emailaddress%20r_liteprofile, but allows user to set whatever scopes they want.This PR fixes issue mentioned in #83.
@d3xt3r2909 Let me know your feedback