-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support fractional bandwidths. #59
Comments
Yes, array-blur has a non-integer radius. Remember that array-blur evolved from this module, but became faster (about 50% if I remember correctly), more versatile, well-tested etc. I can incorporate it back into d3-contour (in src option A, or as a dependency option B), but my preference would still be option C, to make it part of d3-array (d3/d3-array#151, which I would have to update). It's true that the blur() method has a provision for a "width" that allows to grant a pixel matrix topology to the array, but width defaults to 1 and it's a useful 1-d transform, for example for time series. blurring could also be a useful channel transform for Plot (as a complement to windowX, with pros and cons). Let me know which route you'd prefer. Happy to do the change in any case. |
If you are willing I think option C (incorporating Fil/array-blur into d3-array as d3.blur) would be my preference as well. |
* fractional bandwidth, using d3.blur closes #59 * blur2 * accept iterable data; adopt d3-array 3.2.0 Co-authored-by: Mike Bostock <[email protected]>
d3.contourDensity internally rounds the bandwidth:
d3-contour/src/density.js
Line 153 in 06f2cf1
It would be nice to avoid rounding here so that arbitrary bandwidths could be used. Maybe this is possible if we switch to using array-blur, @Fil?
The text was updated successfully, but these errors were encountered: