Dependency Updates and MDX2 support #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nataliepina
force-pushed
the
npina/chore/nov-deps-maintenance
branch
from
bb8baf5 to
847b4c0
Compare
nataliepina
commented
Nov 10, 2022
| ], | ||
| features: { | ||
| previewMdx2: true | ||
| } |
There was a problem hiding this comment.
Required to support mdx2, mdx files will render as blank pages otherwise.
|
🎉 This PR is included in version 11.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After Storybook was updated, a few issues came up with our mdx file rendering which is used for the Welcome, Colors, and Typography pages.
The issues are common and outlined here - storybookjs/storybook#18094
I followed the thread and the suggested workarounds have fixed the issues. In Storybook 7 (coming soon), mdx2 will be fully supported and suggested so we may be able to update some of these configurations at that point.
Additionally, I've had to remove the fragments wrapping the components in the mdx files which were previously required to render multiple components.
Which issue(s) does this PR relate to?
Testing
Trade-offs
Screenshots
Checklist
packages/index.ts