chore: update faker dependency #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes D2IQ-88823
clintonmedbery
requested review from
vacas5,
TattdCodeMonkey,
mstruebing,
seialkali and
nataliepina
nataliepina
approved these changes
May 6, 2022
vacas5
approved these changes
May 6, 2022
There was a problem hiding this comment.
yeah for instance my name is Russ but my email is [email protected] so maybe this is even better fake data
|
🎉 This PR is included in version 10.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes D2IQ-88823
Testing
Go to tables and pagination in storybook. Make sure there is fake data there.
Trade-offs
We were using something called createCard. It would create a "user" with name, email etc. This is deprecated so the name might not be similar to the email in our table. For example with 5 the name might be Bob Ross and the email would be [email protected]. This does not seem to exist in 6 but frankly it is fake data so who cares.
faker-js/faker#528
Dependencies
Faker 6
https://github.com/faker-js/faker
Screenshots
Checklist for PR creator
packages/index.ts