Fix resolvers returning undefined #19
Conversation
| @@ -396,6 +400,22 @@ describe("graphqlObservable", function() { | |||
| m.expect(result.pipe(take(1))).toBeObservable(expected); | |||
| }); | |||
|
|
|||
| // fixme: without `only` all tests pass 🤔 | |||
| itMarbles.only("if defined but returns undefined, field is null", function (m) { | |||
There was a problem hiding this comment.
I sense async induced race conditions. Will check
There was a problem hiding this comment.
It's actually because of this: https://github.com/mesosphere/reactive-graphql/blob/master/src/__tests__/graphqlObservable-test.ts#L338
28 tests skipped with this, 8 without
=> #24
There was a problem hiding this comment.
After merging #24, this kind of fix might be required: getstation@1034b76
|
@DanielMSchmidt do you have the opportunity to look at this please? |
|
Hey @alexstrat Daniel is off for two weeks I will do my best to support the PR :) |
|
@nLight ah ok, good for him! No worry, it can wait 2 weeks if not your priority! |
|
@alexstrat I will take a look at this tomorrow, sorry for the delay 🙇 |
|
I had some time and took a look. I removed ever |
|
@DanielMSchmidt, I'm sorry, I don't understand your last comment 😬
What problem are you refering to? #24 (skipped tests) or #17 (missing field for resolvers returning undefined) |
|
I rebased with master and made necessary changes in aafb8e0 |
|
🎉 This PR is included in version 3.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixes #17
993a417: however, all tests passed even with the failing test case. But it failed (correctly) if I'd run only that case in particular. => #24