This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Update SinkSubscriber to read error message on netty thread #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SinkSubscriber has had it's pipeline slightly changed to ensure that when trying to read an error message response body that it is able to do so. The `ByteBuf` from `response.getContent()` has it's ref-counter automatically decremented when the response object leaves the netty thread and results in the content being disposed. When SinkSubscriber would then attempt to read the content to construct the error message it would fail. This change moves to logic of reading and mapping over the content before we move to the compute thread to invoke the callback on the `SinkOperation`. See ReactiveX/RxNetty#264
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SinkSubscriber has had it's pipeline slightly changed to ensure that
when trying to read an error message response body that it is able to do
so. The
ByteBuffromresponse.getContent()has it's ref-counterautomatically decremented when the response object leaves the netty
thread and results in the content being disposed. When SinkSubscriber
would then attempt to read the content to construct the error message
it would fail.
This change moves to logic of reading and mapping over the content
before we move to the compute thread to invoke the callback on the
SinkOperation.See ReactiveX/RxNetty#264
Fixes #73