This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Add IPSources into config.json.sample, omitting NetInfo #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -93,7 +93,7 @@ The configured name will always be converted to a FQDN by ensuring it ends with | |||
| `enforceRFC952` will enforce an older, more strict set of rules for DNS labels. For details, see the [RFC-952](https://tools.ietf.org/html/rfc952). The default value is `false`. | |||
|
|
|||
| `IPSources` defines a fallback list of IP sources for task records, | |||
| sorted by priority. The default value is: `["netinfo", "mesos", "host"]` | |||
There was a problem hiding this comment.
the default coded value hasn't changed (it's different than what's in config.json.sample, but that's not the same thing as "the default")
There was a problem hiding this comment.
basically, leave "The default value is ..." sentence as-is here
|
lgtm |
sargun
added a commit
that referenced
this pull request
Nov 24, 2015
Add IPSources into config.json.sample, omitting NetInfo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.