This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Transparent proxying of external queries #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 6, 2015
tsenart
changed the title
tsenart
force-pushed
the
rfc5625
branch
2 times, most recently
from
d47912a to
0944e90
Compare
| } else if a = rec(r); a == "" { | ||
| break | ||
| defer func() { | ||
| if total.Inc(); err != nil { |
There was a problem hiding this comment.
this looks strange because the increment of success depends on a negative outcome of total.Inc(). unless I'm missing something, total.Inc() should really be on its own line.
There was a problem hiding this comment.
total.Inc() has no impact on the conditional. It runs unconditionally.
|
a few minor comments. like the cleanness of forwarding vs. recursing 👍 |
This change set follows RFC5625 and implements protocol aware transparent forwarding of DNS messages to external servers. With this we get rid of the poorly implemented recursive semantics of external resolution which were causing issues.
tsenart
added a commit
that referenced
this pull request
Oct 7, 2015
Transparent proxying of external queries
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original external queries code mixed concepts of a proxy (forwarder) and a recurser for no good apparent reason. As per https://tools.ietf.org/html/rfc5625, this change set simplifies things.
Related to #297, #298.
Closes #301.