This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Generate correct SOA and NS records #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SOAMname and SOARname were switched around in a few places which caused SOA and NS records to be wrong. Fixes #295
|
Note to self: Update the |
|
As far as I understand the matter, it lgtm |
| @@ -9,8 +9,8 @@ | |||
| "resolvers": ["8.8.8.8"], | |||
| "timeout": 5, | |||
| "listener": "0.0.0.0", | |||
| "SOAMname": "root.ns1.mesos", | |||
| "SOARname": "ns1.mesos", | |||
| "SOAMname": "ns1.mesos", | |||
There was a problem hiding this comment.
should we specify a sample name that's fully qualified? (ends in a dot)
e.g. ns1.mesos.
|
/cc @karlkfi : could this be related to the flakiness that you're seeing? |
|
@jdef I don't know enough about SOAs or DNS zones to answer that. But I have documented the symptoms here for the time being: kubernetes/kubernetes#14394 (comment) |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SOAMname and SOARname were switched around in a few places which
caused SOA and NS records to be wrong.
Fixes #295