Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

Change in Mesos leader info in ZK may break Mesos-DNS #228

Closed
kozyraki opened this issue Aug 10, 2015 · 9 comments
Closed

Change in Mesos leader info in ZK may break Mesos-DNS #228

kozyraki opened this issue Aug 10, 2015 · 9 comments
Assignees
Labels

Comments

@kozyraki
Copy link
Contributor

Mesos 0.24 will follow this convention for the leading master info in ZK: https://github.com/mesos/commons/blob/master/docs/leader_discovery.rst
https://issues.apache.org/jira/browse/MESOS-2340
This will break existing Mesos-DNS code which assumes the old protobuf.

We need to update the code to handle correctly both 0.24 and older versions :(

@tsenart
Copy link
Contributor

tsenart commented Aug 11, 2015

@kozyraki: As long as they maintain deprecated fields in the Protobufs for backwards compatibility (even if the data isn't filled), addressing this should be pretty easy. It'll be a great opportunity to properly encapsulate the master detection code behind a well defined API that hides these implementation and compatibility constraints.

@cmaloney
Copy link

This is currently preventing using Mesos 0.24 in DCOS. Needs to be fixed ASAP

@jdef
Copy link
Contributor

jdef commented Sep 11, 2015

I've started hacking on a patch in mesos-go

On Fri, Sep 11, 2015 at 1:00 AM, Cody Maloney [email protected]
wrote:

This is currently preventing using Mesos 0.24 in DCOS. Needs to be fixed
ASAP


Reply to this email directly or view it on GitHub
#228 (comment)
.

@jdef
Copy link
Contributor

jdef commented Sep 11, 2015

xref mesos/mesos-go#174

@tsenart
Copy link
Contributor

tsenart commented Sep 11, 2015

@cmaloney: Would you please provide us with a more detailed timeline than ASAP?

@cmaloney
Copy link

It is going to delay multiple projects and likely make them miss their schedules if it is more than a couple business days out.

@tsenart
Copy link
Contributor

tsenart commented Sep 11, 2015

@cmaloney: Thanks.

@jdef
Copy link
Contributor

jdef commented Sep 14, 2015

mesos-go/zk detection has been updated to support the JSON MasterInfo blob, need to incorporate updated Godeps into this project to pull the latest changes from mesos-go

jdef pushed a commit that referenced this issue Sep 14, 2015
@jdef jdef added WIP and removed priority labels Sep 14, 2015
@F21 F21 mentioned this issue Sep 15, 2015
@F21
Copy link

F21 commented Sep 15, 2015

Ran into the problem while trying to use mesos-dns with mesos 0.24 today. Hope this gets merged soon!

@tsenart tsenart mentioned this issue Sep 15, 2015
@tsenart tsenart removed the WIP label Sep 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants