This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
disable configuration cleanup on failed validation (#554) #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
5 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
jkoelker
reviewed
Mar 21, 2019
| @@ -1803,6 +1804,10 @@ def get_arg_parser(): | |||
| parser.add_argument("--skip-validation", | |||
| help="Skip haproxy config file validation", | |||
| action="store_true") | |||
| parser.add_argument("--skip-config-cleanup", | |||
| help="If one app fails, don't try to make configuration " | |||
There was a problem hiding this comment.
Flake8: ./marathon_lb.py:1808:80: E501 line too long (81 > 79 characters)
|
@zliw Apologies for the delay in getting to this pr. Would you mind rebasing this on master and changing the line to pass flake8? If so I'll merge this in. |
|
We've merged this in via #625. Again apologies for the delay and thank you for taking the time to make marathon-lb better. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set introduces an optional command line flag, which allows to skip the new app by app validation/cleanup in favour of the old behaviour:
A broken setup causes no reload of the haproxy.cfg. The old configuration is still usable. The haproxy.cfg is checked once entirely for configuration problems.
Unfortunately for the setup described in #554 the new app-by-app cleanup meant, that some applications would not be accessible anymore after removing them, depending on the order they are delivered by marathon. This currently prevents us from upgrading marathon-lb.