Support providing MLB templates via environment variables rather than… #492
Conversation
|
It's rather difficult to squeeze text into environment variables because of the kind of escaping is required to get it to fit into JSON (e.g. |
|
Yeah so I think I handled it so that it will accept either |
config.py
Outdated
| if os.environ.get(name): | ||
| logger.info('overriding %s from environment variable', name) | ||
| env_template_val = os.environ.get(name) | ||
| # logger.info(env_template_val) |
There was a problem hiding this comment.
Looks like a leftover debug line? Please remove if so
| self.t[template].value = f.read() | ||
| except IOError: | ||
| logger.debug("setting default value for %s", name) | ||
| if os.environ.get(name): |
There was a problem hiding this comment.
Would it be possible to add a test to tests/test_marathon_lb.py? You should be able to do something like
os.environ["key"] = "val"
…rathon-lb into jlee-support-env-templates Catching up to changes on mesosphere/marathon-lb
justinrlee
force-pushed
the
jlee-support-env-templates
branch
from
6ee7c92 to
4a5234d
Compare
justinrlee
force-pushed
the
jlee-support-env-templates
branch
4 times, most recently
from
44c3afd to
1bb98eb
Compare
justinrlee
force-pushed
the
jlee-support-env-templates
branch
from
a07d152 to
bbf89cd
Compare
|
@drewkerrigan I've removed the debug line and added a basic unit test - can you validate? Thanks! |
… template tgz files.
https://jira.mesosphere.com/browse/DCOS-18367