Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Introduce new --strict-mode option. #410

Merged
merged 1 commit into from
Jan 24, 2017
Merged

Introduce new --strict-mode option. #410

merged 1 commit into from
Jan 24, 2017

Conversation

brndnmtthws
Copy link
Contributor

This also adds a new HAPROXY_{n}_ENABLED option, which lets you
enabled/disable individual backends for an app.

This resolves issues #402 and #403.

@JohnOmernik
Copy link

I like this idea, but I think you've mentioned that for backwards compatibility, it's hard to switch enforcement. The security guy in me wants to find a way to make this the default (strict mode) however, I understand the challenges of installed clusters... not sure how to best handle, perhaps with this change make some "marketing" hoopla? Update docs with notes recommending strict mode for new clusters? Recommending people make the change if they can, and then a page on understanding what needs to change?

@brndnmtthws
Copy link
Contributor Author

I'm not comfortable with enabling it by default at the moment. I think we can do a slow transition, but right now it would make a lot of people angry if their apps suddenly broke.

@vishnu2kmohan
Copy link

LGTM

A blog post announcing --strict-mode with a plea to users to port their app definitions to a more secure version (along with a deprecation cycle - 1.5?) would be appreciated.

This also adds a new `HAPROXY_{n}_ENABLED` option, which lets you
enabled/disable individual backends for an app.

This resolves issues #402 and #403.
@brndnmtthws
Copy link
Contributor Author

I'm going to cut the next release as 1.5. I'll target enabling strict mode by default for 1.6.

@brndnmtthws brndnmtthws merged commit b46ace4 into master Jan 24, 2017
@brndnmtthws brndnmtthws deleted the add-strict-mode branch January 24, 2017 20:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants