This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
add tini #383
Merged
add tini #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
brndnmtthws
suggested changes
Dec 16, 2016
| @@ -8,11 +8,16 @@ RUN apt-get update && apt-get install -y --no-install-recommends \ | |||
| python3 \ | |||
| runit \ | |||
| socat \ | |||
| && rm -rf /var/lib/apt/lists/* | |||
| gpg \ | |||
There was a problem hiding this comment.
Shouldn't these be part of the build deps? I don't think they're required at runtime.
| @@ -29,22 +34,24 @@ RUN set -x \ | |||
| wget \ | |||
| ' \ | |||
| && apt-get update \ | |||
| && apt-get install -y --no-install-recommends $buildDeps \ | |||
| && rm -rf /var/lib/apt/lists/* \ | |||
| && apt-get install -y --no-install-recommends $buildDeps \ | |||
| # Install Python packages with --upgrade so we get new packages even if a system | ||
| # package is already installed. Combine with --force-reinstall to ensure we get | ||
| # a local package even if the system package is up-to-date as the system package | ||
| # will probably be uninstalled with the build dependencies. | ||
| && pip3 install --no-cache --upgrade --force-reinstall -r /marathon-lb/requirements.txt \ | ||
| && /marathon-lb/build-haproxy.sh \ | ||
| && gpg --keyserver ha.pool.sks-keyservers.net --recv-keys 595E85A6B1B4779EA4DAAEC70B588DFF0527A9B7 \ |
|
tini and runit have different purposes. tini only prevent zombies in isolated environments, while runit is a (great) service supervisor. |
|
test this please |
|
Why not use |
|
Because we are using the mesos containerizer. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.