This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General cleanup of Python code, mostly around imports and the test runner.
requirements-dev.txt
This will obviously need someone to update the CI settings so that requirements are installed properly and all the tests are run.
There is one more problem with the code that I picked up running
flake8
: this method doesn't actually setip_cache
as it setsip_cache
local to the method, not the module. I'd recommend running a linter likeflake8
as part of the build, but it's a separate command that would need to be added to the CI so I can't do that.