-
Notifications
You must be signed in to change notification settings - Fork 300
Use a separate HAProxy map file for mapping Marathon app IDs to backends #303
Conversation
Can one of the admins verify this patch? |
I don't know if there's a tool that is used to regenerate the documentation? |
It is missing a API endpoint to fetch the app maps. (Lua module to fetch app maps, similar to this) and also documentation for the API endpoint. |
I noticed that, yes. It wouldn't be too hard for me to add something like a |
I think having the API endpoint is worthwhile. If someone plans to use this, I think there'd be an expectation that they'd be able to debug it somehow. |
test this please |
* Generalize getvhostmap.lua to fetch other map files
* Write map files before main config file * Edit temporary config file to include temporary map files so that new map files are validated * Small refactor - generalize some functions that work with temp files
Ready for review again. I've changed a few things:
If there are integration tests for this stuff I'm not sure how to run them? I built & ran my changes manually and the config works as expected and the endpoints to fetch the maps work. |
test this please |
This has a few (small) advantages: