Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

A few improvements #10

Merged
merged 13 commits into from
Oct 30, 2019
Merged

A few improvements #10

merged 13 commits into from
Oct 30, 2019

Conversation

mpereira
Copy link
Contributor

  • bce59a4 Improve metrics documentation.
  • b17b423 Make Prometheus exporter image version composite as well.
  • 7551cc6 Unify handling of Docker images.
  • 50664b7 Set both Docker image namespaces to "mesosphere".
  • 46c9544 Snapshot Docker image versions.
  • 3224748 Change Prometheus exporter Docker image name.
  • 19e349b Build Prometheus exporter Docker image too.
  • 09b0e66 Add automatic formatting for Markdown.

@mpereira mpereira requested a review from viivek46 October 29, 2019 17:03
@mpereira mpereira force-pushed the metrics-improvements branch from 09b0e66 to 857667c Compare October 29, 2019 17:04
@mpereira
Copy link
Contributor Author

The CI check won't pass because the target branch (metrics) broke the tests.

viivek46
viivek46 approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@viivek46 viivek46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mpereira for this PR, it LGTM.

@mpereira mpereira merged commit 360fe5b into metrics Oct 30, 2019
@mpereira mpereira deleted the metrics-improvements branch October 30, 2019 06:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viivek46 viivek46 viivek46 approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpereira @viivek46