Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

fix: adds missing none provisioner in kiali and jaeger #993

Merged
merged 4 commits into from
Apr 12, 2021

Conversation

GoelDeepak
Copy link
Contributor

@GoelDeepak GoelDeepak commented Mar 29, 2021

What type of PR is this?
Bug

What this PR does/ why we need it:
Adds none provisioner in kiali and jaeger

Which issue(s) this PR fixes:
https://jira.d2iq.com/browse/COPS-6877

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

kiali and jaeger are now deployable with the "none" provisioner, i.e. in on-premise environments.

Checklist

  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@GoelDeepak GoelDeepak force-pushed the deepak/fix-kiali-jaeger branch from 4ff10d0 to adef20a Compare March 30, 2021 16:05
@makkes
Copy link
Contributor

makkes commented Mar 31, 2021

The failing install test log says:

2021-03-31T07:53:24.400181518Z     TestIstioGroup: log_hook.go:110: cluster addon jaeger was in status deploying when testing ended
2021-03-31T07:53:24.400184237Z     TestIstioGroup: log_hook.go:110: cluster addon kiali was in status deploying when testing ended

@joejulian joejulian modified the milestones: release/next, release/4.0 Mar 31, 2021
@joejulian joejulian modified the milestones: release/4.0, release/next Apr 7, 2021
@joejulian
Copy link
Contributor

@mesosphere-mergebot backport release/4

@d2iq-mergebot
Copy link
Contributor

Backport PR for release/4: #1022

@joejulian joejulian enabled auto-merge (squash) April 12, 2021 22:41
@joejulian joejulian merged commit 661e65a into master Apr 12, 2021
@joejulian joejulian deleted the deepak/fix-kiali-jaeger branch April 12, 2021 23:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants