This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
chore: clean up kommander versions #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kommander as a chart/product will be 1.0.0 when GA, this unpins its version from kommaner UI
we can split up later if necessary
shaneutt
reviewed
Jan 21, 2020
There was a problem hiding this comment.
LGTM, this kind of deprecation and re-working is supported, however we need review from @dkoshkin just to double verify: we're fixing broken version information, does anything in Konvoy rely on this metadata which could break upgrades or otherwise?
shaneutt
approved these changes
Jan 22, 2020
dkoshkin
approved these changes
Jan 22, 2020
|
@gracedo do you think this will negatively impact the UI? |
joejulian
approved these changes
Jan 22, 2020
natmegs
approved these changes
Jan 23, 2020
|
🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kommander as a chart/product will be 1.0.0 when GA, this unpins its version from kommaner UI
--
Waiting for mesosphere/charts#375 - I'm going to update chartversion here once thats merged