chore: update kommander annotations #68

natmegs · 2020-01-13T23:39:38Z

Update kommander monitoring addon endpoints
Update kommander UI endpoint
Add grafana annotations to kommander addon
Bump kommander and opsportal charts

natmegs · 2020-01-13T23:40:58Z

@shaneutt can you let me know if this follows the correct contribution pattern?

natmegs · 2020-01-13T23:45:11Z

addons/kommander/1.163.x/kommander-2.yaml

+    endpoint.kubeaddons.mesosphere.io/kommander-grafana: "/ops/portal/kommander/monitoring/grafana"
+    docs.kubeaddons.mesosphere.io/thanos: "https://thanos.io/getting-started.md/"
+    docs.kubeaddons.mesosphere.io/karma: "https://github.com/prymitive/karma"
+    docs.kubeaddons.mesosphere.io/kommander-grafana: "https://grafana.com/docs/"


@gracedo it's kind of hard to see in the diff but all that's changed in these files are the annotations - specifically, the endpoints (changed to the /ops/portal/kommander/monitoring/x pattern per slack), and adding annotations for kommander's grafana. Also changed the kommander UI endpoint as I think that the monitoring endpoint changes are dependent on the ui path change? Let me know if this looks right!

gracedo

Let's wait on this until the charts work is all done (I was planning on modifying the annotations with the kommander bump). I was told that maybe prior to GA it was okay to modify instead of create a new revision, but I'm also not entirely sure :p

natmegs · 2020-01-13T23:48:11Z

@gracedo Ok - I'll label this blocked for now until the charts stuff is ready

gracedo

mesosphere/charts#351 was merged so we should be unblocked now!

gracedo · 2020-01-14T18:42:29Z

addons/kommander/1.163.x/kommander-2.yaml

+  chartReference:
+    chart: kommander
+    repo: https://mesosphere.github.io/charts/stable
+    version: 0.3.3


Let's update this to 0.3.10 (mesosphere/charts#351)

make that 0.3.13, pushed up a fix :) mesosphere/charts#356

I think this should be kept as is since we're not updating the addon itself, 0.3.13 is added for 1.182.x versions.
that said, I'm not sure if we can/need to add these annotations to 1.163.x versions, they dont even support it, right?

since we're not updating the kommander chart version here, do we need this file addons/kommander/1.163.x/kommander-2.yaml?

gracedo · 2020-01-14T18:42:35Z

addons/kommander/1.173.x/kommander-2.yaml

+  chartReference:
+    chart: kommander
+    repo: https://mesosphere.github.io/charts/stable
+    version: 0.3.9


Let's update this to 0.3.10 (mesosphere/charts#351)

same comment/question as above

shaneutt

I think we should consider updating to the latest patch version as @gracedo suggested, and then ✔️

addons/kommander/1.163.x/kommander-2.yaml

juliangieseke · 2020-01-15T09:11:18Z

I took 1.173.x/kommander-2.yaml and copied it to 1.182.x/kommander-1.yaml - adding our latest version.

I can see that maintaining that many versions will get messy kinda fast…

juliangieseke · 2020-01-15T09:21:24Z

addons/kommander/1.163.x/kommander-2.yaml

+  chartReference:
+    chart: kommander
+    repo: https://mesosphere.github.io/charts/stable
+    version: 0.3.3


I think this should be kept as is since we're not updating the addon itself, 0.3.13 is added for 1.182.x versions.
that said, I'm not sure if we can/need to add these annotations to 1.163.x versions, they dont even support it, right?

juliangieseke · 2020-01-15T09:22:04Z

addons/kommander/1.173.x/kommander-2.yaml

+  chartReference:
+    chart: kommander
+    repo: https://mesosphere.github.io/charts/stable
+    version: 0.3.9


same comment/question as above

addons/kommander/1.182.x/kommander-1.yaml

juliangieseke · 2020-01-15T11:28:40Z

tested this PR on my cluster, its running 1.182.14 and uses /ui/ url, so it seems to be fine 👍

shaneutt

I've spoken with @juliangieseke about this in Zoom and Slack, and discussed some of the confusion related to this PR:

We are working on expanded documentation which will cover how to make releases and how to manage removing unsupported versions of an Addon which appear will be particularly helpful for Kommander which is updating rapidly and older versions are not necessarily useful to keep around.

You can track the documentation that's being created here: https://jira.mesosphere.com/browse/DCOS-62869

In the meantime, I believe we can merge this as is to get the immediate benefit of getting the patched latest revision out.

After we publish our new documentation it should be much simpler and more autonomous to do so without needing assistance from other repository code owners, @juliangieseke and I are planning on getting this fully resolved and set into motion next tuesday.

^

shaneutt · 2020-01-15T13:37:49Z

I'm going to look into the CI issues as per DCOS-62937

shaneutt · 2020-01-15T16:02:45Z

So far the CI issues appear as though they may be deficiencies in teamcity resources, as I can pass the KommanderTestGroup tests locally. I'm continuing my review.

shaneutt · 2020-01-15T16:13:59Z

CI may have just been flaky, as tests are now passing. Please re-review and get this one moving through.

gracedo

Hmm, karma seems to be at the old /kommander/monitoring/karma url instead of behind /ops/portal/kommander - blocking this to investigate further

natmegs · 2020-01-15T19:36:02Z

We are going to have another chart bump shortly for kommander and I'd like to get that in here as well before it merges.

natmegs · 2020-01-15T21:35:23Z

I added a new commit to change from kommander 1.182.x to 1.184.x and to also update the opsportal chart. This is now blocked on mesosphere/charts#361

juliangieseke · 2020-01-16T10:22:09Z

I think it was also blocked on mesosphere/charts#360 - I've merged that and tested this branch on my cluster. thanos & grafana are accessible on /ops/portal/kommander/{query, grafana} paths 👍 Lets get this in 💯

juliangieseke · 2020-01-16T18:18:24Z

@gracedo can you please unblock this pr? 🙇

gracedo · 2020-01-16T18:19:32Z

@juliangieseke just starting up a cluster now to check. or - if you still have yours up running this version, can you check /ops/portal/kommander/karma?

Remove unnecessary value overrides.

juliangieseke · 2020-01-16T19:21:32Z

I've cleaned up this PR to match the one for 1.3.0-rc.1 branch (#84). @jimmidyson kept your commit, but its still broken

natmegs requested review from joejulian and shaneutt as code owners January 13, 2020 23:39

natmegs requested a review from gracedo January 13, 2020 23:39

natmegs commented Jan 13, 2020

View reviewed changes

gracedo suggested changes Jan 13, 2020

View reviewed changes

natmegs added the blocked label Jan 13, 2020

gracedo suggested changes Jan 14, 2020

View reviewed changes

gracedo added ready and removed blocked labels Jan 14, 2020

shaneutt assigned natmegs Jan 14, 2020

shaneutt suggested changes Jan 14, 2020

View reviewed changes

addons/kommander/1.163.x/kommander-2.yaml Outdated Show resolved Hide resolved

juliangieseke mentioned this pull request Jan 15, 2020

Kommander 1.182.14 #74

Closed

juliangieseke force-pushed the nat/kommander-addons branch 2 times, most recently from 03f8105 to f034ca1 Compare January 15, 2020 09:10

juliangieseke previously requested changes Jan 15, 2020

View reviewed changes

shaneutt self-requested a review January 15, 2020 13:30

shaneutt previously approved these changes Jan 15, 2020

View reviewed changes

shaneutt self-assigned this Jan 15, 2020

shaneutt dismissed their stale review via 5e4fb31 January 15, 2020 15:58

shaneutt requested review from gracedo, juliangieseke and shaneutt January 15, 2020 16:14

shaneutt previously approved these changes Jan 15, 2020

View reviewed changes

juliangieseke previously approved these changes Jan 15, 2020

View reviewed changes

gracedo suggested changes Jan 15, 2020

View reviewed changes

gracedo mentioned this pull request Jan 15, 2020

kommander: Update kommander-karma dependency mesosphere/charts#360

Merged

natmegs dismissed stale reviews from juliangieseke and shaneutt via 07124f2 January 15, 2020 21:33

natmegs added blocked and removed ready labels Jan 15, 2020

natmegs requested review from juliangieseke, shaneutt and gracedo January 15, 2020 21:35

natmegs added ready and removed blocked labels Jan 15, 2020

juliangieseke previously approved these changes Jan 16, 2020

View reviewed changes

juliangieseke mentioned this pull request Jan 16, 2020

[1.3.0] backport latest kommander bump #84

Merged

jimmidyson dismissed juliangieseke’s stale review via 91f229b January 16, 2020 16:58

juliangieseke and others added 3 commits January 16, 2020 20:19

chore: bump kommander addon

2b9b349

Go mod tidy && verify

4312d3a

chore(kommander): Bump KCL chart version

a8f2864

Remove unnecessary value overrides.

juliangieseke force-pushed the nat/kommander-addons branch from 91f229b to a8f2864 Compare January 16, 2020 19:20

juliangieseke merged commit cff56ac into master Jan 17, 2020

juliangieseke deleted the nat/kommander-addons branch January 17, 2020 13:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update kommander annotations #68

chore: update kommander annotations #68

natmegs commented Jan 13, 2020 •

edited

Loading

natmegs commented Jan 13, 2020

natmegs Jan 13, 2020

gracedo left a comment

natmegs commented Jan 13, 2020

gracedo left a comment

gracedo Jan 14, 2020

gracedo Jan 15, 2020

juliangieseke Jan 15, 2020

gracedo Jan 15, 2020

gracedo Jan 14, 2020

gracedo Jan 15, 2020

juliangieseke Jan 15, 2020

shaneutt left a comment

juliangieseke commented Jan 15, 2020

juliangieseke Jan 15, 2020

juliangieseke Jan 15, 2020

juliangieseke commented Jan 15, 2020

shaneutt left a comment

shaneutt commented Jan 15, 2020

shaneutt commented Jan 15, 2020

shaneutt commented Jan 15, 2020

gracedo left a comment

natmegs commented Jan 15, 2020

natmegs commented Jan 15, 2020

juliangieseke commented Jan 16, 2020 •

edited

Loading

juliangieseke commented Jan 16, 2020

gracedo commented Jan 16, 2020

juliangieseke commented Jan 16, 2020

chore: update kommander annotations #68

chore: update kommander annotations #68

Conversation

natmegs commented Jan 13, 2020 • edited Loading

natmegs commented Jan 13, 2020

Choose a reason for hiding this comment

gracedo left a comment

Choose a reason for hiding this comment

natmegs commented Jan 13, 2020

gracedo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shaneutt left a comment

Choose a reason for hiding this comment

juliangieseke commented Jan 15, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

juliangieseke commented Jan 15, 2020

shaneutt left a comment

Choose a reason for hiding this comment

shaneutt commented Jan 15, 2020

shaneutt commented Jan 15, 2020

shaneutt commented Jan 15, 2020

gracedo left a comment

Choose a reason for hiding this comment

natmegs commented Jan 15, 2020

natmegs commented Jan 15, 2020

juliangieseke commented Jan 16, 2020 • edited Loading

juliangieseke commented Jan 16, 2020

gracedo commented Jan 16, 2020

juliangieseke commented Jan 16, 2020

natmegs commented Jan 13, 2020 •

edited

Loading

juliangieseke commented Jan 16, 2020 •

edited

Loading