This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoshkin
approved these changes
Nov 16, 2020
samvantran
approved these changes
Nov 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment - this lgtm 👍
RELEASE_NOTES.md
Outdated
Comment on lines
22
to
23
- support being upgraded from v0.10 to v1.0.3. ([#594](https://github.com/mesosphere/kubernetes-base-addons/pull/594), [@jr0d](https://github.com/jr0d)) | ||
- support upgrading from v0.10.1 to v1.0.3 ([#656](https://github.com/mesosphere/kubernetes-base-addons/pull/656), [@jr0d](https://github.com/jr0d)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these two seem to be saying the same thing, can combine and just put the two PRs at the end?
joejulian
added a commit
that referenced
this pull request
Dec 15, 2020
* feat: bump for cert-manager-upgrade (#594) * feat: bump for cert-manager-upgrade * fix: use the correct image * use log for log output instead of stdout * Update addons/cert-manager/cert-manager.yaml Co-authored-by: Grace Do <[email protected]> * Update test/scripts/test-wrapper.go Co-authored-by: Grace Do <[email protected]> Co-authored-by: Joe Julian <[email protected]> Co-authored-by: Grace Do <[email protected]> * chore: bump cert-manager (#607) * Update CODEOWNERS (#606) * [prometheus-adapter] chore: change chart origin (#603) * [prometheus-adapter] chore: change chart origin * change revision version * Update addons/prometheusadapter/prometheusadapter.yaml Co-authored-by: Grace Do <[email protected]> * fix chart name Co-authored-by: Grace Do <[email protected]> * [external-dns] chore: change chart location (#601) * [external-dns] chore: change chart location * fix issue with chart name * chore: bump cert-manager * chore: Bump revision and values Co-authored-by: Shane Utt <[email protected]> Co-authored-by: Alejandro Escobar <[email protected]> Co-authored-by: Grace Do <[email protected]> * bump prometheus-operator chart * Add a new label for kommander to require (#655) Signed-off-by: Dimitri Koshkin <[email protected]> * feat: adds cert-manager-upgrade automation (#656) * cert manager v0.4.1 (#659) * fix: add change to fix kubefed certificate * chore: bump revision * fix: ensure organization is set (#662) * add requires cert-manager: v1 (#664) * add requires cert-manager: v1 * add cert-manager requires for dex * [cert-manager] chart bump (#674) * chart bump * update v ref * 3.0.0 Release Notes (#676) * Release notes for 3.0.0 * fix: use chart version that does not contain patch (#722) Co-authored-by: Jared Rodriguez <[email protected]> Co-authored-by: Grace Do <[email protected]> Co-authored-by: Hector Fernandez <[email protected]> Co-authored-by: Shane Utt <[email protected]> Co-authored-by: Alejandro Escobar <[email protected]> Co-authored-by: Dimitri Koshkin <[email protected]> Co-authored-by: Steve Chung <[email protected]>
joejulian
added a commit
that referenced
this pull request
Jan 12, 2021
* feat: bump for cert-manager-upgrade (#594) * feat: bump for cert-manager-upgrade * fix: use the correct image * use log for log output instead of stdout * Update addons/cert-manager/cert-manager.yaml Co-authored-by: Grace Do <[email protected]> * Update test/scripts/test-wrapper.go Co-authored-by: Grace Do <[email protected]> Co-authored-by: Joe Julian <[email protected]> Co-authored-by: Grace Do <[email protected]> * chore: bump cert-manager (#607) * Update CODEOWNERS (#606) * [prometheus-adapter] chore: change chart origin (#603) * [prometheus-adapter] chore: change chart origin * change revision version * Update addons/prometheusadapter/prometheusadapter.yaml Co-authored-by: Grace Do <[email protected]> * fix chart name Co-authored-by: Grace Do <[email protected]> * [external-dns] chore: change chart location (#601) * [external-dns] chore: change chart location * fix issue with chart name * chore: bump cert-manager * chore: Bump revision and values Co-authored-by: Shane Utt <[email protected]> Co-authored-by: Alejandro Escobar <[email protected]> Co-authored-by: Grace Do <[email protected]> * bump prometheus-operator chart * Add a new label for kommander to require (#655) Signed-off-by: Dimitri Koshkin <[email protected]> * feat: adds cert-manager-upgrade automation (#656) * cert manager v0.4.1 (#659) * fix: add change to fix kubefed certificate * chore: bump revision * fix: ensure organization is set (#662) * add requires cert-manager: v1 (#664) * add requires cert-manager: v1 * add cert-manager requires for dex * [cert-manager] chart bump (#674) * chart bump * update v ref * 3.0.0 Release Notes (#676) * Release notes for 3.0.0 * fix: use chart version that does not contain patch (#722) Co-authored-by: Jared Rodriguez <[email protected]> Co-authored-by: Grace Do <[email protected]> Co-authored-by: Hector Fernandez <[email protected]> Co-authored-by: Shane Utt <[email protected]> Co-authored-by: Alejandro Escobar <[email protected]> Co-authored-by: Dimitri Koshkin <[email protected]> Co-authored-by: Steve Chung <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Documentation
What this PR does/ why we need it:
Release Notes
Which issue(s) this PR fixes:
Special notes for your reviewer:
People who use selfie sticks really need to have a good, long look at themselves.
Does this PR introduce a user-facing change?:
Checklist