Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

external-dns: Add servicemonitor metrics label #617

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

gracedo
Copy link
Contributor

@gracedo gracedo commented Oct 23, 2020

What type of PR is this?

Feature

What this PR does/ why we need it:

Enables metrics collection by adding the servicemonitor label

Which issue(s) this PR fixes:

https://jira.d2iq.com/browse/D2IQ-72698

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

external-dns: Add servicemonitor label to enable metrics collection by Prometheus

Checklist

  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@gracedo gracedo requested review from a team as code owners October 23, 2020 21:41
@gracedo gracedo self-assigned this Oct 23, 2020
@gracedo gracedo added the ready label Oct 23, 2020
@gracedo gracedo requested a review from a team October 23, 2020 21:42
@gracedo
Copy link
Contributor Author

gracedo commented Oct 23, 2020

Tested manually on a cluster
image
image

Copy link
Contributor

@samvantran samvantran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had a question but not blocking since your manual tests show it works 👍

values: |
rbac:
create: true
service:
labels:
servicemonitor.kubeaddons.mesosphere.io/path: "metrics"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need to add a name like for other fixes? eg like this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for external-dns, we can reuse an existing servicemonitor that just selects on that one label (https://github.com/mesosphere/kubernetes-base-addons/blob/master/addons/prometheus/prometheus.yaml#L83-L86)

@samvantran samvantran merged commit c703a0a into master Oct 23, 2020
@samvantran samvantran deleted the gracedo/external-dns_label_D2IQ-72698 branch October 23, 2020 23:49
@gracedo gracedo added this to the release/3.1 milestone Oct 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants