This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armandgrillet
approved these changes
Oct 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the Dispatch CI issue doesn't seem to be related:
STAGE [Deploying Enabled Addons]
dashboard [OK]
konvoyconfig [OK]
reloader [OK]
external-dns [OK]
opsportal [OK]
cert-manager [OK]
defaultstorageclass-protection [OK]
gatekeeper [OK]
traefik [OK]
dex [OK]
awsebscsiprovisioner [OK]
traefik-forward-auth [OK]
kube-oidc-proxy [OK]
dex-k8s-authenticator [OK]
prometheus [OK]
velero [OK]
prometheusadapter [OK]
elasticsearch [OK]
elasticsearch-curator [OK]
elasticsearchexporter [OK]
fluentbit [OK]
kibana [OK]
Error: failed to deploy the cluster: the following 1 addons failed to deploy: [ kommander ]
makkes
approved these changes
Oct 23, 2020
shaneutt
suggested changes
Oct 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to fork or bump metallb in particular, please hold on that one 🥺
This has to happen regardless of the future of metallb. We should merge this and the metallb changes should be rebased on it. |
shaneutt
approved these changes
Oct 23, 2020
gracedo
pushed a commit
that referenced
this pull request
Dec 22, 2020
gracedo
pushed a commit
that referenced
this pull request
Dec 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
chore
What this PR does/ why we need it:
The helm stable chart repo is being retired. We have forked these charts and will now need to reference them in the repo field.
Which issue(s) this PR fixes:
https://jira.d2iq.com/browse/D2IQ-72545
Special notes for your reviewer:
This depends on mesosphere/charts#852
Does this PR introduce a user-facing change?:
Checklist