Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

require repo for stable charts #614

Merged
merged 1 commit into from
Oct 23, 2020
Merged

require repo for stable charts #614

merged 1 commit into from
Oct 23, 2020

Conversation

joejulian
Copy link
Contributor

What type of PR is this?

chore

What this PR does/ why we need it:

The helm stable chart repo is being retired. We have forked these charts and will now need to reference them in the repo field.

Which issue(s) this PR fixes:

https://jira.d2iq.com/browse/D2IQ-72545

Special notes for your reviewer:
This depends on mesosphere/charts#852

Does this PR introduce a user-facing change?:

none

Checklist

  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@joejulian joejulian requested review from a team as code owners October 23, 2020 05:32
@joejulian joejulian self-assigned this Oct 23, 2020
Copy link
Contributor

@armandgrillet armandgrillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the Dispatch CI issue doesn't seem to be related:

STAGE [Deploying Enabled Addons]
dashboard                                                              [OK]
konvoyconfig                                                           [OK]
reloader                                                               [OK]
external-dns                                                           [OK]
opsportal                                                              [OK]
cert-manager                                                           [OK]
defaultstorageclass-protection                                         [OK]
gatekeeper                                                             [OK]
traefik                                                                [OK]
dex                                                                    [OK]
awsebscsiprovisioner                                                   [OK]
traefik-forward-auth                                                   [OK]
kube-oidc-proxy                                                        [OK]
dex-k8s-authenticator                                                  [OK]
prometheus                                                             [OK]
velero                                                                 [OK]
prometheusadapter                                                      [OK]
elasticsearch                                                          [OK]
elasticsearch-curator                                                  [OK]
elasticsearchexporter                                                  [OK]
fluentbit                                                              [OK]
kibana                                                                 [OK]

Error: failed to deploy the cluster: the following 1 addons failed to deploy: [ kommander ]

Copy link
Contributor

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to fork or bump metallb in particular, please hold on that one 🥺

@joejulian
Copy link
Contributor Author

This has to happen regardless of the future of metallb. We should merge this and the metallb changes should be rebased on it.

@shaneutt shaneutt self-requested a review October 23, 2020 14:51
@joejulian joejulian added ready and removed blocked labels Oct 23, 2020
@joejulian joejulian merged commit 7aff912 into master Oct 23, 2020
@joejulian joejulian deleted the joe/require_repo branch October 23, 2020 16:40
gracedo pushed a commit that referenced this pull request Dec 22, 2020
gracedo pushed a commit that referenced this pull request Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants