This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
fix: fluentbit should not keep retrying indefinitely #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gracedo
reviewed
Oct 9, 2020
duh, sorry |
gracedo
approved these changes
Oct 9, 2020
branden
suggested changes
Oct 9, 2020
Co-authored-by: Branden Rolston <[email protected]>
branden
approved these changes
Oct 9, 2020
|
dispatch-e2e-test is failing because Kommander is currently broken. I'll go ahead and merge. |
branden
pushed a commit
that referenced
this pull request
Oct 10, 2020
* fix: fluentbit should not keep retrying indefinitely * revision bump * Update addons/fluentbit/fluentbit.yaml Co-authored-by: Branden Rolston <[email protected]> Co-authored-by: Branden Rolston <[email protected]> (cherry picked from commit e32cfad)
This was referenced Oct 10, 2020
branden
added a commit
that referenced
this pull request
Oct 12, 2020
* fix: fluentbit should not keep retrying indefinitely (#589) * fix: fluentbit should not keep retrying indefinitely * revision bump * Update addons/fluentbit/fluentbit.yaml Co-authored-by: Branden Rolston <[email protected]> Co-authored-by: Branden Rolston <[email protected]> (cherry picked from commit e32cfad) * Bump fluent-bit to 0.7.3 (#584) Co-authored-by: Branden Rolston <[email protected]> (cherry picked from commit f7de10d) Co-authored-by: Alejandro Escobar <[email protected]> Co-authored-by: D2iQ Dispatch <[email protected]>
branden
added a commit
that referenced
this pull request
Oct 12, 2020
* fix: fluentbit should not keep retrying indefinitely (#589) * fix: fluentbit should not keep retrying indefinitely * revision bump * Update addons/fluentbit/fluentbit.yaml Co-authored-by: Branden Rolston <[email protected]> Co-authored-by: Branden Rolston <[email protected]> (cherry picked from commit e32cfad) * Bump fluent-bit to 0.7.3 (#584) Co-authored-by: Branden Rolston <[email protected]> (cherry picked from commit f7de10d) Co-authored-by: Alejandro Escobar <[email protected]> Co-authored-by: D2iQ Dispatch <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
BUG
What this PR does/ why we need it:
Keep retrying on errors causes us to keep them perpetually in memory and fill out our buffer choking off fluentbit from pushing logs
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Checklist