Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Prometheus version Bump and default resource increase #333

Merged
merged 3 commits into from
Jul 2, 2020

Conversation

geekbass
Copy link
Contributor

@geekbass geekbass commented Jul 1, 2020

  • Chart Version bump

  • Update Prometheus Version to latest as we do on soak - D2IQ-69855

  • Set default limits based on what we do for soak - D2IQ-69797

What type of PR is this? Chore

What this PR does/ why we need it: To complete JIRA tickets: D2IQ-69797, D2IQ-69855. This covers some bug fixes and also applies a new limits to Prometheus to avoid the continuous OOM upon restarts.

These changes are already running in our AWS Soak stack and are based on these changes.

Which issue(s) this PR fixes: D2IQ-69797, D2IQ-69855

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Checklist

  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

- Chart Version bump

- Update Prometheus Version to latest as we do on soak - D2IQ-69855

- Set default limits based on what we do for soak - D2IQ-69797
@geekbass geekbass requested a review from a team as a code owner July 1, 2020 18:54
@geekbass geekbass requested review from sebbrandt87 and gracedo July 1, 2020 20:18
Copy link
Contributor

@gracedo gracedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 comment then lgtm, thanks!

addons/prometheus/0.38.x/prometheus-9.yaml Outdated Show resolved Hide resolved
@geekbass geekbass requested review from gracedo and branden July 1, 2020 22:07
@samvantran
Copy link
Contributor

unrelated test failure with Istio

@samvantran samvantran merged commit f2ebe99 into master Jul 2, 2020
@samvantran samvantran deleted the geekbass/prometheus-work branch July 2, 2020 03:02
joejulian pushed a commit that referenced this pull request Jul 9, 2020
* Prometheus Work

- Chart Version bump

- Update Prometheus Version to latest as we do on soak - D2IQ-69855

- Set default limits based on what we do for soak - D2IQ-69797

* adding new values for the prometheus image version and for default wal compression enabled

* rolling back version since we dont need a bump now
joejulian pushed a commit that referenced this pull request Jul 22, 2020
* Prometheus Work

- Chart Version bump

- Update Prometheus Version to latest as we do on soak - D2IQ-69855

- Set default limits based on what we do for soak - D2IQ-69797

* adding new values for the prometheus image version and for default wal compression enabled

* rolling back version since we dont need a bump now
joejulian pushed a commit that referenced this pull request Jul 22, 2020
* Prometheus Work

- Chart Version bump

- Update Prometheus Version to latest as we do on soak - D2IQ-69855

- Set default limits based on what we do for soak - D2IQ-69797

* adding new values for the prometheus image version and for default wal compression enabled

* rolling back version since we dont need a bump now
joejulian pushed a commit that referenced this pull request Jul 23, 2020
* Prometheus Work

- Chart Version bump

- Update Prometheus Version to latest as we do on soak - D2IQ-69855

- Set default limits based on what we do for soak - D2IQ-69797

* adding new values for the prometheus image version and for default wal compression enabled

* rolling back version since we dont need a bump now
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants