Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

prometheus: Bump chart to latest version #308

Merged
merged 5 commits into from
Jun 24, 2020

Conversation

gracedo
Copy link
Contributor

@gracedo gracedo commented Jun 23, 2020

What type of PR is this?

Chore

What this PR does/ why we need it:

Bumps prometheus-operator chart to latest version which adds a grafana dashboard for autoscaler. Also reverted #298 because it did not create a new revision file, so went back and did that here as well.

Which issue(s) this PR fixes:

https://jira.d2iq.com/browse/D2IQ-64989

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

\[prometheus\]: Update prometheus-operator chart, which adds a grafana dashboard for monitoring autoscaler

Checklist

  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@gracedo gracedo added the ready label Jun 23, 2020
@gracedo gracedo requested review from hectorj2f and a team June 23, 2020 17:22
@gracedo gracedo requested a review from a team as a code owner June 23, 2020 17:22
@gracedo gracedo self-assigned this Jun 23, 2020
cpu: 200m
memory: 250Mi
cpu: 100m
memory: 50Mi
Copy link
Contributor

@samvantran samvantran Jun 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't we want to bump these values though? I think your commit c9689de got overwritten?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it in prometheus-3.yaml the PR #298 that bumped them should have created a new revision file (prometheus-3.yaml) but instead the previous prometheus-2.yaml was overwritten

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh that was my miss 👍

cpu: 200m
memory: 250Mi
cpu: 100m
memory: 50Mi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh that was my miss 👍

@gracedo gracedo force-pushed the gracedo/bump_prom_autoscaler_dash_D2IQ-64989 branch from 410f301 to e614dbf Compare June 23, 2020 23:26
@joejulian joejulian merged commit 076e777 into master Jun 24, 2020
@joejulian joejulian deleted the gracedo/bump_prom_autoscaler_dash_D2IQ-64989 branch June 24, 2020 03:40
joejulian pushed a commit that referenced this pull request Jul 8, 2020
* Revert "chore: bump alert-manager resource limits (#298)"

This reverts commit 3b547b2.

* chore: Copy previous prometheus revision

* chore: Bump alert-manager resource limits

* chore: Copy previous prometheus revision

* chore: Bump prometheus-operator to latest chart version
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants