Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

fix: update dka init container #291

Merged
merged 2 commits into from
Jun 15, 2020
Merged

fix: update dka init container #291

merged 2 commits into from
Jun 15, 2020

Conversation

mhrabovcin
Copy link
Contributor

@mhrabovcin mhrabovcin commented Jun 11, 2020

What type of PR is this?
Bug

What this PR does/ why we need it:
Bumps DKA init container that fixes the bug described in the linked JIRA.

Which issue(s) this PR fixes:
https://jira.d2iq.com/browse/D2IQ-69354

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[dex-k8s-authenticator] Fix bug in init container that could remove custom CA certificate from main cluster login instructions

Checklist

  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@mhrabovcin mhrabovcin requested a review from a team as a code owner June 11, 2020 16:33
@jr0d
Copy link
Contributor

jr0d commented Jun 12, 2020

delta:

10c10
<     catalog.kubeaddons.mesosphere.io/addon-revision: "1.1.2-1"
---
>     catalog.kubeaddons.mesosphere.io/addon-revision: "1.1.2-2"
74c74
<         image: mesosphere/kubeaddons-addon-initializer:v0.2.8
---
>         image: mesosphere/kubeaddons-addon-initializer:v0.2.11

Copy link
Contributor

@samvantran samvantran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a release note as this fixes a bug?

@mhrabovcin
Copy link
Contributor Author

mhrabovcin commented Jun 15, 2020

@samvantran could you please help me navigate how to add proper release for this PR?

I've added release not block to the PR description.

@joejulian joejulian merged commit 075becf into master Jun 15, 2020
@joejulian joejulian deleted the mh/dex-k8s-auth branch June 15, 2020 23:07
joejulian pushed a commit that referenced this pull request Jun 19, 2020
joejulian pushed a commit that referenced this pull request Jul 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants