Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

bumping init-container in traefik #286

Merged
merged 3 commits into from
Jun 15, 2020
Merged

bumping init-container in traefik #286

merged 3 commits into from
Jun 15, 2020

Conversation

GoelDeepak
Copy link
Contributor

@GoelDeepak GoelDeepak commented Jun 8, 2020

What type of PR is this?
Bug

What this PR does/ why we need it:
This PR bumps the init-container version to include a bug fix. The fix allows clusterhostname to be an IP address.

Which issue(s) this PR fixes:
none

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

\[traefik\] fix an issue where `clusterhostname` can now be an ipaddress as well

Checklist

  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@GoelDeepak GoelDeepak requested a review from a team as a code owner June 8, 2020 18:55
@GoelDeepak GoelDeepak force-pushed the deepak/clusterhostname branch from 03da7e0 to f777205 Compare June 8, 2020 19:02
@samvantran
Copy link
Contributor

Please add release notes as this fixes a bug

@GoelDeepak
Copy link
Contributor Author

Please add release notes as this fixes a bug

Added. Though, its a grey area whether its a bug or a feature. Different people might view it differently. :)

@samvantran
Copy link
Contributor

Added. Though, its a grey area whether its a bug or a feature. Different people might view it differently. :)

Thanks! Either is okay with me. Mostly I just wanted to call out that it affects the user at the end of the day

@GoelDeepak GoelDeepak force-pushed the deepak/clusterhostname branch from f777205 to cc5d647 Compare June 11, 2020 08:32
@joejulian joejulian merged commit a877cc3 into master Jun 15, 2020
@joejulian joejulian deleted the deepak/clusterhostname branch June 15, 2020 23:02
joejulian pushed a commit that referenced this pull request Jun 19, 2020
* chore: copy from previous version

* chore: bump the init-container version from 0.2.9 to 0.2.10

Co-authored-by: Alejandro Escobar <[email protected]>
joejulian pushed a commit that referenced this pull request Jul 8, 2020
* chore: copy from previous version

* chore: bump the init-container version from 0.2.9 to 0.2.10

Co-authored-by: Alejandro Escobar <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants