Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

feature: adding auditlog dashboards #254

Merged
merged 2 commits into from
May 15, 2020
Merged

feature: adding auditlog dashboards #254

merged 2 commits into from
May 15, 2020

Conversation

alejandroEsc
Copy link
Contributor

@alejandroEsc alejandroEsc commented May 14, 2020

What type of PR is this?

Feature

What this PR does/ why we need it:

Adding dashboards to our kibana deployments

Which issue(s) this PR fixes:

https://jira.d2iq.com/browse/D2IQ-67322

Special notes for your reviewer:
Sorry but rebasing screwed up my commits, so here are the diffs

diff kibana-4.yaml kibana-3.yaml
10c10
<     catalog.kubeaddons.mesosphere.io/addon-revision: "6.8.2-3"
---
>     catalog.kubeaddons.mesosphere.io/addon-revision: "6.8.2-2"
99,102d98
<       dashboardImport:
<         enabled: true
<         dashboards:
<           audit-logs-dashboards: '{"objects":[{"id":"19422f60-93e2-11e8-83ef-b5593250e6b7"

Does this PR introduce a user-facing change?:

Kibana: Importing an Audit-Search dashboard and 2 Audit-Search visualizations to help search through audit logs.

Checklist

  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@alejandroEsc alejandroEsc requested a review from a team as a code owner May 14, 2020 18:56
@alejandroEsc
Copy link
Contributor Author

Additional Visualizations now imported automatically:
Screen Shot 2020-05-14 at 11 38 17 AM

Audit-Dashboard:
Screen Shot 2020-05-14 at 11 38 35 AM

Audit-Search Visualization:
Screen Shot 2020-05-14 at 11 39 58 AM

@samvantran samvantran changed the title chore: adding auditlog dash-baords chore: adding auditlog dashboards May 14, 2020
Copy link
Contributor

@samvantran samvantran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 👍

@alejandroEsc alejandroEsc requested a review from samba May 14, 2020 21:41
@alejandroEsc alejandroEsc self-assigned this May 14, 2020
Copy link

@samba samba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great first iteration. Let's get it running in Soak.

For some follow up on some UX improvements, I'd like to see:

  • line charts (over time) instead of the current pie charts
  • easier filtering for namespace and user columns
    • something like a list of all known options for these, with checkboxes, like when applying a column filter to Google Spreadsheet.

@samba samba changed the title chore: adding auditlog dashboards feature: adding auditlog dashboards May 14, 2020
@alejandroEsc
Copy link
Contributor Author

Changed to using bar graphs for the dashboard to visually see the options.

Screen Shot 2020-05-15 at 1 43 44 PM

Copy link
Contributor

@branden branden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deployed this and played around with it, looks great. This is gonna be useful. +1 on the bar charts.

Copy link
Contributor

@gracedo gracedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great! 💯

@branden branden merged commit 10d8ad3 into master May 15, 2020
@branden branden deleted the ae/kibanadashboard branch May 15, 2020 22:24
@samvantran samvantran mentioned this pull request Jun 10, 2020
joejulian pushed a commit that referenced this pull request Jun 19, 2020
* chore: adding auditlog dash-baords

* moved away from pie-charts to bar charts
joejulian pushed a commit that referenced this pull request Jul 22, 2020
* chore: adding auditlog dash-baords

* moved away from pie-charts to bar charts
joejulian pushed a commit that referenced this pull request Jul 22, 2020
* chore: adding auditlog dash-baords

* moved away from pie-charts to bar charts
joejulian pushed a commit that referenced this pull request Jul 23, 2020
* chore: adding auditlog dash-baords

* moved away from pie-charts to bar charts
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants