-
Notifications
You must be signed in to change notification settings - Fork 21
Adds an option to look for grafana dashboards in all namespaces #245
Conversation
CI failure in https://teamcity.mesosphere.io/viewLog.html?buildId=2734250&buildTypeId=ClosedSource_Konvoy_KonvoyE2eAwsKba&tab=buildLog&_focus=22234 looks like the flake reported in https://jira.d2iq.com/browse/D2IQ-66636 and other tickets, I would suggest re-running Logs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the change in test/go.sum
is unexpected but shouldn't be an issue.
f132fe9
to
be38584
Compare
path: /ops/portal/grafana | ||
sidecar: | ||
dashboards: | ||
searchNamespace: ALL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were you able to confirm if this works? I know it's always been a limitation in the prometheus-operator chart vs standalone grafana chart that the grafana sidecar is only able to pull in dashboards from the same namespace. It's possible the docs just haven't been updated (seen this before with other options..) but if you verified that it works then +1!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I have verified and it works. :)
be38584
to
cc2e5e4
Compare
* Make a copy of existing file * Add an option to look for grafana dashboards in all namespaces
* Make a copy of existing file * Add an option to look for grafana dashboards in all namespaces
* Make a copy of existing file * Add an option to look for grafana dashboards in all namespaces
* Make a copy of existing file * Add an option to look for grafana dashboards in all namespaces
What type of PR is this?
Chore
What this PR does/ why we need it:
It enables grafana to look for all namespaces for grafana dashboards configmaps