Skip to content
This repository was archived by the owner on Dec 4, 2024. It is now read-only.

Adds an option to look for grafana dashboards in all namespaces #245

Merged
merged 2 commits into from
May 16, 2020

Conversation

GoelDeepak
Copy link
Contributor

What type of PR is this?
Chore

What this PR does/ why we need it:
It enables grafana to look for all namespaces for grafana dashboards configmaps

@GoelDeepak GoelDeepak requested a review from a team as a code owner May 9, 2020 10:25
@armandgrillet
Copy link
Contributor

CI failure in https://teamcity.mesosphere.io/viewLog.html?buildId=2734250&buildTypeId=ClosedSource_Konvoy_KonvoyE2eAwsKba&tab=buildLog&_focus=22234 looks like the flake reported in https://jira.d2iq.com/browse/D2IQ-66636 and other tickets, I would suggest re-running Konvoy - e2e (aws).

Logs:

[[konvoy-e2e] Provisioning own clusters [aws][pull-request][OS] should create a cluster and upgrade it with AWS AMI - ubuntu1604] [2] Kubernetes cluster destroyed successfully!
[14:44:28][[konvoy-e2e] Provisioning own clusters [aws][pull-request][OS] should create a cluster and upgrade it with AWS AMI - ubuntu1604] [2] 
[14:44:28][[konvoy-e2e] Provisioning own clusters [aws][pull-request][OS] should create a cluster and upgrade it with AWS AMI - ubuntu1604] /root/src/github.com/mesosphere/konvoy/tests/e2e/provisioning.go:285
[14:44:28]
[[konvoy-e2e] Provisioning own clusters [aws][pull-request][OS] should create a cluster and upgrade it with AWS AMI - ubuntu1604] error running up: exit status 1
Unexpected error:
    <*exec.ExitError | 0xc000745ca0>: {
        ProcessState: {
            pid: 15886,
            status: 256,
            rusage: {
                Utime: {Sec: 0, Usec: 180000},
                Stime: {Sec: 0, Usec: 44000},
                Maxrss: 100280,
                Ixrss: 0,
                Idrss: 0,
                Isrss: 0,
                Minflt: 12970,
                Majflt: 0,
                Nswap: 0,
                Inblock: 0,
                Oublock: 16,
                Msgsnd: 0,
                Msgrcv: 0,
                Nsignals: 0,
                Nvcsw: 3280,
                Nivcsw: 644,
            },
        },
        Stderr: nil,
    }
    exit status 1
occurred
/root/src/github.com/mesosphere/konvoy/tests/e2e/functions.go:1262

Copy link
Contributor

@armandgrillet armandgrillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the change in test/go.sum is unexpected but shouldn't be an issue.

path: /ops/portal/grafana
sidecar:
dashboards:
searchNamespace: ALL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to confirm if this works? I know it's always been a limitation in the prometheus-operator chart vs standalone grafana chart that the grafana sidecar is only able to pull in dashboards from the same namespace. It's possible the docs just haven't been updated (seen this before with other options..) but if you verified that it works then +1!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I have verified and it works. :)

@GoelDeepak GoelDeepak merged commit f049d00 into master May 16, 2020
@GoelDeepak GoelDeepak deleted the deepak/grafana branch May 16, 2020 13:01
joejulian pushed a commit that referenced this pull request Jun 19, 2020
* Make a copy of existing file

* Add an option to look for grafana dashboards in all namespaces
joejulian pushed a commit that referenced this pull request Jul 22, 2020
* Make a copy of existing file

* Add an option to look for grafana dashboards in all namespaces
joejulian pushed a commit that referenced this pull request Jul 22, 2020
* Make a copy of existing file

* Add an option to look for grafana dashboards in all namespaces
joejulian pushed a commit that referenced this pull request Jul 23, 2020
* Make a copy of existing file

* Add an option to look for grafana dashboards in all namespaces
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants