Skip to content
This repository was archived by the owner on Dec 4, 2024. It is now read-only.

traefik: update initContainer #221

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

armandgrillet
Copy link
Contributor

@armandgrillet armandgrillet commented Apr 17, 2020

What type of PR is this?
Chore

What this PR does/ why we need it:
Bump the ClusterAddon to use kubeaddons-addon-initializer:v0.2.9 which results in Traefik printing a bit more logs.
Also bump the values.chart.helm.kubeaddons.mesosphere.io/traefik to the latest version available in mesosphere/charts.

Which issue(s) this PR fixes:
https://jira.d2iq.com/browse/D2IQ-66751

Special notes for your reviewer:
Tested manually by spinning up a Konvoy cluster and replacing the Traefik ClusterAddon.
In comparison, here is the previous addon definition: https://github.com/mesosphere/kubernetes-base-addons/blob/1bd6d5eeec0f98bc4a460ae01dc882d3e0d38a27/addons/traefik/1.7.x/traefik-8.yaml

Does this PR introduce a user-facing change?:

NONE

Checklist

  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@armandgrillet armandgrillet requested a review from makkes April 17, 2020 15:28
@armandgrillet armandgrillet requested a review from a team as a code owner April 17, 2020 15:28
@armandgrillet armandgrillet self-assigned this Apr 17, 2020
@makkes makkes requested a review from a team April 20, 2020 08:05
@tillt
Copy link
Contributor

tillt commented Apr 20, 2020

Noticed that the values got bumped as well and now wonder if that should be part of the PR description.

@armandgrillet
Copy link
Contributor Author

@tillt True, I have updated the PR description following your comment.

@armandgrillet armandgrillet merged commit 06623d1 into master Apr 20, 2020
@armandgrillet armandgrillet deleted the bump-traefik-kubeaddons-addon-initializer branch April 20, 2020 08:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants