Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

[auto-bump][chart] metallb-0.12.3 #1361

Closed
wants to merge 1 commit into from
Closed

Conversation

d2iq-dispatch
Copy link
Contributor

What type of PR is this?
Bug

What this PR does/ why we need it:
Duplicate keys cause Flux to fail, see fluxcd/helm-controller#283 Additionally, the node-role.kubernetes.io/master will no longer be removed/lost in case when new tolerations are defined.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Defining custom tolerations for metallb speaker no longer results in removing/forgetting of `node-role.kubernetes.io/master` toleration.

Checklist

  • If a chart is changed, the chart version is correctly incremented.
  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@d2iq-dispatch d2iq-dispatch requested review from a team as code owners November 24, 2021 11:50
@d2iq-dispatch d2iq-dispatch added the help wanted Extra attention is needed label Nov 24, 2021
@d2iq-mergebot
Copy link
Contributor

This repo has @mesosphere-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@mesosphere-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.

@mesosphere-mergebot backport  

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
addon/metallb help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants