This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This repo has @mesosphere-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@mesosphere-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.
|
jongiddy
force-pushed
the
jongiddy/D2IQ-75146-dex-defer-authrequests
branch
from
May 4, 2021 15:30
60e8d4c
to
8f20d25
Compare
gracedo
reviewed
May 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addon revision should be bumped as well
jongiddy
force-pushed
the
jongiddy/D2IQ-75146-dex-defer-authrequests
branch
from
May 4, 2021 16:17
8f20d25
to
cd0a57b
Compare
hectorj2f
approved these changes
May 5, 2021
jongiddy
force-pushed
the
jongiddy/D2IQ-75146-dex-defer-authrequests
branch
from
May 5, 2021 09:24
cd0a57b
to
54e0994
Compare
makkes
approved these changes
May 5, 2021
jongiddy
force-pushed
the
jongiddy/D2IQ-75146-dex-defer-authrequests
branch
from
May 5, 2021 11:21
54e0994
to
5004961
Compare
Force-push to sign commit |
Signed-off-by: Jonathan Giddy <[email protected]>
jongiddy
force-pushed
the
jongiddy/D2IQ-75146-dex-defer-authrequests
branch
from
May 5, 2021 12:33
5004961
to
3ba63c6
Compare
@mesosphere-mergebot backport release/3 release/4 |
This was referenced May 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Chore
What this PR does/ why we need it:
Bump
dex
to include a change that defers creation of AuthRequest objects to avoid Denial of Service.Which issue(s) this PR fixes:
https://jira.d2iq.com/browse/COPS-6867
https://jira.d2iq.com/browse/D2IQ-75146
Special notes for your reviewer:
Tested in https://github.com/mesosphere/yakcl/pull/425
Does this PR introduce a user-facing change?:
Checklist