Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

[auto-bump][chart] kubernetes-dashboard-4.0.3 #1024

Merged
merged 6 commits into from
Apr 15, 2021

Conversation

d2iq-dispatch
Copy link
Contributor

@d2iq-dispatch d2iq-dispatch commented Apr 9, 2021

https://github.com/kubernetes/dashboard/tree/master/aio/deploy/helm-chart/kubernetes-dashboard#version-4xx

Add Release Notes or "None":
Starting from version 4.0.0 of this chart, it will only support Helm 3 and remove the support for Helm 2

This is automated bump triggered from the source repo containing the updated Chart/Addon.

@d2iq-dispatch d2iq-dispatch requested a review from a team as a code owner April 9, 2021 03:01
@d2iq-dispatch d2iq-dispatch added help wanted Extra attention is needed needs release notes This PR needs the PR comment release-note block labels Apr 9, 2021
@d2iq-mergebot
Copy link
Contributor

This repo has @mesosphere-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@mesosphere-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.

@mesosphere-mergebot backport  

@joejulian joejulian added this to the release/next milestone Apr 9, 2021
@gracedo gracedo removed the needs release notes This PR needs the PR comment release-note block label Apr 9, 2021
@joejulian joejulian added ready and removed help wanted Extra attention is needed labels Apr 13, 2021
@joejulian joejulian requested a review from a team April 13, 2021 17:35
@joejulian joejulian enabled auto-merge (squash) April 13, 2021 17:36
@joejulian joejulian requested review from s12chung and a team April 13, 2021 21:46
@s12chung
Copy link
Contributor

s12chung commented Apr 13, 2021

so we're going to not match the app-version with the addon-revision anymore? if so, i'll ✅ . i dunno the status of that.

@joejulian
Copy link
Contributor

I've proposed, many times, that matching a version of the Addon definition to anything but the version of the addon file is problematic at best. Now, because of the error with the app version, the only way to make them match is to go backwards with the revision which sounds like a worse idea and will make the linter fail.

@s12chung
Copy link
Contributor

s12chung commented Apr 14, 2021

whichever direction we go, as long as there is alignment and consistency, I'll go. it's just the consistency weirdness that holds me back.

@joejulian
Copy link
Contributor

@s12chung Who else would you like to see aligned here?

@s12chung
Copy link
Contributor

@joejulian you ok bringing it up in the next standup? i'll make a reminder for myself.

@joejulian
Copy link
Contributor

sure

Copy link
Contributor

@s12chung s12chung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as confirmed during standup

@joejulian joejulian merged commit ba80705 into master Apr 15, 2021
@joejulian joejulian deleted the bump-kubernetes-dashboard-b976639e branch April 15, 2021 18:30
@joejulian
Copy link
Contributor

@mesosphere-mergebot backport release/3 release/4

@d2iq-mergebot
Copy link
Contributor

Backport PR for release/3: #1057
Conflicts present in files:

addons/dashboard/dashboard.yaml

Backport PR for release/4: #1058

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants