This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
[INFINITY-3520] Make Kafka ciphers configurable and have a secure default. #2483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found out the issue. OpenSSL and the JVM use different naming schemes for cipher suites:
|
benclarkwood
approved these changes
Apr 18, 2018
|
Surprisingly enough, Java is the one following the standard in this case! |
mpereira
added a commit
that referenced
this pull request
Apr 18, 2018
…secure default. (#2483) * Plumb cipher configuration through. * Add tests. * Handle RFC cipher suite names. * Ciphers are separated by commas in the service configuration. * Of course I forgot to include this file.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds plumbing for a new configuration for TLS cipher suites:
service.security.transport_encryption.ciphers. That value is plumbed directly to Kafka'sserver.propertiesssl.cipher.suitesconfiguration.However, Kafka doesn't seem to be accepting the current default configuration value. It is a comma-separated list of cipher suite names prefixed withTLS_. I added the prefix after seeing it on a couple of places. I've tried it without the prefix too, to no avail. Ifservice.security.transport_encryption.ciphersis left blank Kafka accepts connections with the 21 ciphers we saw before. The documentation isn't very specific and doesn't provide example values.I've tried:- WithTLS_prefix, separated by dashes. e.g.:TLS_AES128-GCM-SHA256,...- WithoutTLSprefix, separated by dashes. e.g.:AES128-GCM-SHA256,...- WithTLS_prefix, separated by underscores. e.g.:TLS_AES128_GCM_SHA256,...- WithoutTLSprefix, separated by underscores. e.g.:AES128_GCM_SHA256,...I'll look into this tomorrow morning unless someone feels like taking a swing at it. The added test is currently failing due to the above.Examples of configuringssl.cipher.suitesin the wild:- IBM/sarama#643 (comment)- https://phabricator.wikimedia.org/T182993#3855423