with-poll flag is passed to configure

[aaronjensen]

Fixes #738

[aaronjensen]

Still working on testing this.

[aaronjensen]

Tested with 31. From what I could see, this likely never worked.

[d12frosted]

good catch

[d12frosted]

You don't need to pass it. We apply a patch:

  local_patch "poll", sha: "59e876f82e6fd8e4583bc2456339eda4f989c86b1e16a02b0726702e95f60825" if build.with? "poll"

or am I missing something?

[aaronjensen]

@d12frosted AFAICT, the patch adds a build option that defaults to off, so we need to specify it to enable the new code:

https://github.com/d12frosted/homebrew-emacs-plus/blob/master/patches/emacs-29/poll.patch#L9-L20

[d12frosted]

Oh. In that case we need to keep the option, but revert the deletion of the following line:

args << "--with-poll" if build.with? "poll"

[aaronjensen]

@d12frosted not sure I understand... I moved the line because it was in the wrong place. Do we need it twice for some reason?

[d12frosted]

Oh sorry, my bad. Looked at the wrong file 🤦 . Your fix seems legit - adding to args needs to be done BEFORE autogen / configure 😅

And you are right, the commit that added this option never actually enable it 🤦