Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dala 5396 add ikb logo #959

Merged
merged 9 commits into from
Feb 11, 2025
Merged

Dala 5396 add ikb logo #959

merged 9 commits into from
Feb 11, 2025

Conversation

saz-im-netz
Copy link
Contributor

@saz-im-netz saz-im-netz commented Feb 10, 2025

Pull Request <Title>

<Description here>

Things to do during Peer Review

Please check all boxes before the Pull Request is merged. In case you skip a box, describe in the PRs description (that means: here) why the check is skipped.

  • The GitHub Actions for the CI are green. This is enforced by GitHub.
  • The PR has been peer-reviewed
    • The code has been manually inspected by someone who did not implement the feature
    • If this PR includes work on the frontend, at least one @ts-nocheck is removed. Additionally, there should not be any @ts-nocheck in files modified by this PR. If no @ts-nocheck are left: Celebrate 🎉 🎊 type-safety and remove this entry.
  • The PR actually implements what is described in the JIRA-Issue
  • At least one test exists testing the new feature
    • Make sure all newly added functionality (especially user facing) is tested
    • Make sure that new test files are included in a test container and actually run in the CI
  • At least 3 consecutive CI runs are successfully executed to ensure that there are no flaky tests.
  • Documentation is updated as required. If unsure whether or what to update, ask a fellow developer.
  • If there was a database entity class added, there must also be a migration script for creating the corresponding database if flyway is already used by the service
  • IF there are changes done to the framework data models or to a database entity class, the following steps were completed in order
    • A fresh clone of dataland.com is generated (see Wiki page on "OTC" for details)
    • The feature branch is deployed to clone with Reset non-user related Docker Volumes & Re-populate turned off
    • It's verified that the CD run is green
    • The new feature is manually used/tested/observed on the clone server. Testing of the new feature should (also) be done by a second, independent reviewer from the dev team
    • The feature branch is deployed to one of the dev servers with Reset non-user related Docker Volumes & Re-populate turned on, and it's verified that the CD run is green
  • ELSE, the new version is deployed to one of the dev servers using this branch
    • Run with setting Reset non-user related Docker Volumes & Re-populate turned on
    • It's verified that this version actually is the one deployed (check gitinfo for branch name and commit id!)
    • It's verified that the CD run is green
    • The new feature is manually used/tested/observed on dev server. Testing of the new feature should (also) be done by a second, independent reviewer from the dev team
  • Confirm that the latest version (use the /gitinfo endpoint) of the feature branch is deployed to one of the dev servers (no longer enforced by GitHub)

@juliacialkowski juliacialkowski merged commit 15cdf13 into main Feb 11, 2025
49 checks passed
@juliacialkowski juliacialkowski deleted the DALA-5396_Add-IKB-logo branch February 11, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants