Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for card UkrCard #81

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Added support for card UkrCard #81

merged 1 commit into from
Oct 18, 2021

Conversation

umair-fayaz
Copy link
Contributor

Fixes #46

aloisdg
aloisdg approved these changes Oct 16, 2021
View reviewed changes
Copy link
Member

@aloisdg aloisdg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job :)

@aloisdg aloisdg added enhancement New feature or request hacktoberfest hacktoberfest-accepted A pull request is considered approved once it has an overall approving review from maintainers, or h labels Oct 16, 2021
@aloisdg aloisdg added this to the v1 milestone Oct 16, 2021
saboco
saboco approved these changes Oct 18, 2021 •
edited
Loading
View reviewed changes
saboco
saboco approved these changes Oct 18, 2021 •
edited
Loading
View reviewed changes
saboco
saboco approved these changes Oct 18, 2021
View reviewed changes
Copy link
Collaborator

@saboco saboco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for me

@aloisdg aloisdg merged commit a3631cc into d-edge:main Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saboco saboco saboco approved these changes

@aloisdg aloisdg aloisdg approved these changes

@sambegaonkar1212 sambegaonkar1212 Awaiting requested review from sambegaonkar1212

@Tarmil Tarmil Awaiting requested review from Tarmil

Assignees

@umair-fayaz umair-fayaz

Labels
enhancement New feature or request hacktoberfest hacktoberfest-accepted A pull request is considered approved once it has an overall approving review from maintainers, or h
Projects
None yet
Milestone
v1
Development

Successfully merging this pull request may close these issues.

Add support for card UkrCard
3 participants
@umair-fayaz @aloisdg @saboco