Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace old link with GitHub's release #68

Closed
aloisdg opened this issue Oct 7, 2021 · 2 comments · Fixed by #69
Closed

Replace old link with GitHub's release #68

aloisdg opened this issue Oct 7, 2021 · 2 comments · Fixed by #69
Assignees
@Ananthavijay
Labels
good first issue Good for newcomers hacktoberfest hacktoberfest-accepted A pull request is considered approved once it has an overall approving review from maintainers, or h
Milestone
v1

Comments

@aloisdg
Copy link
Member

aloisdg commented Oct 7, 2021

Hi!

Why bother generating RELEASE_NOTES.md when GitHub to the job?

To do list:

  • Remove RELEASE_NOTES.md file
  • Replace lib's link with https://github.com/d-edge/Cardizer/releases/
@aloisdg aloisdg added good first issue Good for newcomers hacktoberfest hacktoberfest-accepted A pull request is considered approved once it has an overall approving review from maintainers, or h labels Oct 7, 2021
@Ananthavijay
Copy link
Contributor

Can I work on this issue?

@aloisdg
Copy link
Member Author

aloisdg commented Oct 7, 2021

@Ananthavijay sure go ahead

@aloisdg aloisdg added this to the v1 milestone Oct 7, 2021
@Ananthavijay Ananthavijay mentioned this issue Oct 7, 2021
Merged
aloisdg pushed a commit that referenced this issue Oct 7, 2021
@Ananthavijay
ci: replaced old link with Github's release (#69)
921157e 
* Remove Release_Notes.md
* Replaced the lib's link

Fix #68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ananthavijay Ananthavijay

Labels
good first issue Good for newcomers hacktoberfest hacktoberfest-accepted A pull request is considered approved once it has an overall approving review from maintainers, or h
Projects
None yet
Milestone
v1
Development

Successfully merging a pull request may close this issue.

Replaced old link with Github's release
2 participants
@aloisdg @Ananthavijay