Avoids issue #360 on qt.py example #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cztomczak
reviewed
Feb 18, 2018
examples/qt.py
Outdated
| @@ -108,6 +108,8 @@ class MainWindow(QMainWindow): | |||
| def __init__(self): | |||
| # noinspection PyArgumentList | |||
| super(MainWindow, self).__init__(None) | |||
| # Avoids crash when shutting down CEF (issue #360) | |||
| self.setAttribute(Qt.WA_DeleteOnClose, True) | |||
There was a problem hiding this comment.
Have you tested this code with pyqt4 and pyqt5? If not then maybe we should execute it only after checking the PYSIDE constant variable.
There was a problem hiding this comment.
I've added the guard just in case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#360