Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url error #273

Closed
wrecode opened this issue Nov 18, 2016 · 2 comments
Closed

url error #273

wrecode opened this issue Nov 18, 2016 · 2 comments
Labels
bug
Milestone
v55

Comments

@wrecode
Copy link

wrecode commented Nov 18, 2016

in linux. if url is file:///home/xxx.html?param=1
CreateBrowserSync this url.
the url format to file:///home/xxx.html%3Fparam%3D1
can't open this url.
@cztomczak
Copy link
Owner

cztomczak commented Nov 19, 2016 •
edited
Loading

Url is being modified via GetNavigateUrl: https://github.com/cztomczak/cefpython/blob/cefpython54/src/utils.pyx#L85

Seems that urllib_pathname2url() function is causing this issue. There was already a fix for "#" character being encoded, a similar solution for "?", "=" and "&" characters should be applied:

        # Allow hash when loading urls. The pathname2url function
        # replaced hashes with "%23" (Issue 114).
        url = url.replace("%23", "#")

Related issue: #114

cztomczak added a commit that referenced this issue Dec 15, 2016
@cztomczak
Update to Chrome 55.0.2883.59 and CEF 3.2883.1539.gd7f087e (#271).
bfc0a25 
Update to Cython 0.25.2.

Fix Certificate Transparency support causing some SSL sites fail
to load after some time (#279).

Fix ApplicationSettings.cache_path not working (#283).

Fix: Not a clean shutdown in examples, when closing app while browser
is still loading a website (#282).

Fix loading local filesystem urls that contained any of ? & =
characters (#273).

Fix Request.SetPostData and GetPostData segmentation faults (#228).

Add ApplicationSettings.net_security_expiration_enabled.

Update ExecuteJavascript docs with scriptUrl="" and startLine=1
default params. Also worth noting that ExecuteJavascript crashed
in earlier CEF versions when startLine wasn't provided or was <= 0
(Issue #268).

Add a test that measures execution time for calling Python function
from javascript and then js callback.

Add Contributing guidelines / Issue template.

Update automate.py, include ceftests executable.
@cztomczak
Copy link
Owner

Fixed in bfc0a25. v55.2 released, please test.

@cztomczak cztomczak added this to the v55 milestone Feb 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v55
Development

No branches or pull requests
2 participants
@cztomczak @wrecode